nit: redundant call to sb.toString before print
#2464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'Command line arguments' chapter ends with the following code snippet: ... sb.toString println(sb) and those two lines IMHO should be replaced with one as: * 'sb.toString' performs actual string materialisation from buffer and returns it, but nothing is actually using it * 'println(sb)' relies on StringBuilder having properly implemented 'toString' method (which is obviously the case) and calls it implicitly again and prints it to the std out this time I have proposed to reduce it to 'println(sb.toString)' to give clear intent of 'toString' being actually used to produce the content that is outputted but 'println(sb)' would do to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command line argumentschapter ends with the following code snippet:and those two lines IMHO should be replaced with one as:
sb.toStringperforms actual string materialisation from buffer and returns it,but nothing is actually using it
println(sb)relies on StringBuilder having properly implementedtoStringmethod (which is obviously the case) and calls it implicitly again and prints
it to the std out this time
I have proposed to reduce it to
println(sb.toString)to give clear intent oftoStringbeing actually used to produce the content that is outputted but
println(sb)woulddo to, WDYT?